Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android tv-casting-app: Fixing issues with handling responses for Media commands #22701

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Android tv-casting-app: Fixing issues with handling responses for Media commands #22701

merged 1 commit into from
Sep 16, 2022

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented Sep 16, 2022 •
edited
Loading

Issue Being Resolved

Change overview

  1. Updated how the response Handler is passed to the lambda in C++ calling the Java response handler.
  2. Added the required _1 as separator for the new Media commands (added after contentLauncherLaunchUrl) to satisfy JNI naming requirements.
  3. Added StackLocks before making calls into the SDK for each of the JNI methods for the media commands.

Testing

Tested using the Android tv-casting-app example.

@andy31415
Copy link
Contributor

Accept for 1.0: examples change

@github-actions
Copy link

PR #22701: Size comparison from 0574c55 to a43bdcd

Increases (2 builds for telink)
platform target config section 0574c55 a43bdcd change % change
telink light-switch-app tlsr9518adk80d text 574592 574594 2 0.0
ota-requestor-app tlsr9518adk80d text 598994 598996 2 0.0
Decreases (3 builds for bl702, nrfconnect)
platform target config section 0574c55 a43bdcd change % change
bl702 lighting-app bl702 .debug_info 37895074 37895073 -1 -0.0
.text 956778 956776 -2 -0.0
bl702+rpc .debug_info 41801677 41801676 -1 -0.0
.text 1030480 1030478 -2 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182067 1182051 -16 -0.0
text 815284 815280 -4 -0.0
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 0574c55 a43bdcd change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188011 1188011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506733 1506733 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486412 486412 0 0.0
.debug_info 37895074 37895073 -1 -0.0
.debug_line 5252158 5252158 0 0.0
.debug_loc 3362165 3362165 0 0.0
.debug_ranges 359712 359712 0 0.0
.debug_str 3455785 3455785 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956778 956776 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1283939 1283939 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644312 1644312 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511788 511788 0 0.0
.debug_info 41801677 41801676 -1 -0.0
.debug_line 5626697 5626697 0 0.0
.debug_loc 3554872 3554872 0 0.0
.debug_ranges 382168 382168 0 0.0
.debug_str 3851752 3851752 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030480 1030478 -2 -0.0
k32w light k32w0+release (read/write) 649900 649900 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574392 574392 0 0.0
lock k32w0+release (read/write) 706856 706856 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630892 630892 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10353156 10353156 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503860 503860 0 0.0
.text 8195348 8195348 0 0.0
thermostat-no-ble arm64 (read only) 2385500 2385500 0 0.0
(read/write) 143457 143457 0 0.0
.bss 55297 55297 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77112 77112 0 0.0
.dynamic 560 560 0 0.0
.got 5160 5160 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 143444 143444 0 0.0
.text 2000048 2000048 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455640 2455640 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418284 1418284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182067 1182051 -16 -0.0
bss 143633 143633 0 0.0
rodata 144196 144196 0 0.0
text 815284 815280 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160703 1160703 0 0.0
bss 142860 142860 0 0.0
rodata 135768 135768 0 0.0
text 803152 803152 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130812 1130812 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577908 577908 0 0.0
lock-app qpg6105+debug (read/write) 1101792 1101792 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548892 548892 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813692 813692 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574592 574594 2 0.0
lighting-app tlsr9518adk80d (read/write) 835648 835648 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592754 592754 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843756 843756 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598994 598996 2 0.0

@andy31415 andy31415 merged commit 989ad8e into project-chip:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.0] Android tv-casting-app crashes when handling response for media commands
3 participants
@sharadb-amazon @andy31415 @chrisdecenzo